Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: add lease not found and deadline exceed to retryable errors #56630

Merged
merged 4 commits into from
Oct 16, 2024
Merged

ddl: add lease not found and deadline exceed to retryable errors #56630

merged 4 commits into from
Oct 16, 2024

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Oct 14, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #56550

Problem Summary:

[2024/10/02 17:46:51.687 +08:00] [INFO] [info.go:1001] ["get key failed"] [key=/tidb/server/info] [error="context deadline exceeded"]
[2024/10/02 17:46:52.841 +08:00] [WARN] [manager.go:536] ["close session error"] [error="etcdserver: requested lease not found"]
[2024/10/02 17:46:52.841 +08:00] [ERROR] [backfilling_operators.go:962] ["import error"] [task-id=120028] [subtask-id=120055] [category=ddl] [error="etcdserver: requested lease not found"]
[2024/10/02 17:46:52.841 +08:00] [INFO] [backend.go:352] ["engine close start"] [category=ddl-ingest] [engineTag=sbtest1:35] [engineUUID=dd035f55-b760-5f2e-b67a-4e79ffec0f3d]
[2024/10/02 17:46:52.842 +08:00] [INFO] [backend.go:354] ["engine close completed"] [category=ddl-ingest] [engineTag=sbtest1:35] [engineUUID=dd035f55-b760-5f2e-b67a-4e79ffec0f3d] [takeTime=860.297µs] []
[2024/10/02 17:46:52.842 +08:00] [INFO] [backend.go:413] ["cleanup start"] [category=ddl-ingest] [engineTag=sbtest1:35] [engineUUID=dd035f55-b760-5f2e-b67a-4e79ffec0f3d]
[2024/10/02 17:46:52.948 +08:00] [INFO] [reorg.go:451] ["run reorg job wait timeout"] [category=ddl] ["wait time"=5s] ["total added row count"=70003100]
[2024/10/02 17:46:52.949 +08:00] [INFO] [job_worker.go:981] ["schema version doesn't change"] [category=ddl] [jobID=430]
[2024/10/02 17:46:52.956 +08:00] [INFO] [job_worker.go:763] ["run DDL job"] [category=ddl] [jobID=430] [conn=3544189572] [job="ID:430, Type:add index, State:running, SchemaState:write reorganization, SchemaID:358, TableID:245, RowCount:70003100, ArgLen:0, start time: 2024-10-02 17:43:21.782 +0800 CST, Err:<nil>, ErrCount:0, SnapshotVersion:452948709115691080, Version: v1, UniqueWarnings:0"]
[2024/10/02 17:46:52.960 +08:00] [INFO] [index.go:1211] ["index backfill state running"] [category=ddl] ["job ID"=430] [table=sbtest1] ["ingest mode"=true] [index=index_test_1727862201803]

This is introduced by #56184.

What changed and how does it work?

Add "lease not found" and "deadline exceed" to retryable errors.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2024
@tangenta tangenta changed the title ddl: add 'lease not found' and 'deadline exceed' to retryable errors ddl: add lease not found and deadline exceed to retryable errors Oct 14, 2024
@tiprow tiprow
Copy link

tiprow bot commented Oct 14, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.1262%. Comparing base (ca8d322) to head (d68df9b).
Report is 19 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #56630         +/-   ##
=================================================
- Coverage   73.4053%   57.1262%   -16.2791%     
=================================================
  Files          1629       1778        +149     
  Lines        449951     639599     +189648     
=================================================
+ Hits         330288     365379      +35091     
- Misses        99390     249156     +149766     
- Partials      20273      25064       +4791
Flag Coverage Δ
integration 39.3583% <92.3076%> (?)
unit 72.4745% <69.2307%> (-0.0653%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1546% <ø> (+17.5687%) ⬆️

D3Hunter
D3Hunter reviewed Oct 14, 2024
View reviewed changes
pkg/owner/manager.go Outdated Show resolved Hide resolved
pkg/ddl/index.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-14 07:56:34.356163905 +0000 UTC m=+257791.505073729: ☑️ agreed by D3Hunter.
  • 2024-10-14 08:30:29.399129898 +0000 UTC m=+259826.548039726: ☑️ agreed by wjhuang2016.

@lance6716
Copy link
Contributor

/retest

@tiprow tiprow
Copy link

tiprow bot commented Oct 14, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

/retest

@tangenta
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Oct 15, 2024

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Oct 15, 2024

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
Copy link
Contributor

/retest

@tiprow tiprow
Copy link

tiprow bot commented Oct 15, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Oct 16, 2024

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 1352db6 into pingcap:master Oct 16, 2024
24 checks passed
@tangenta tangenta added the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Oct 16, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #56690.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 16, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 21, 2024
@ti-chi-bot
ddl: add lease not found and deadline exceed to retryable errors (#…
3792db2 
…56630) (#56690)

close #56550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
6 participants
@tangenta @lance6716 @hawkingrei @ti-chi-bot @D3Hunter @wjhuang2016